planner: fix cannot binding for deleting multi table with alias #57255
+76
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
qw4990
reviewed
Nov 12, 2024
ti-chi-bot
bot
added
size/L
qw4990
reviewed
Nov 15, 2024
ti-chi-bot
bot
added
size/M
ti-chi-bot
bot
removed
do-not-merge/work-in-progress
hawkingrei
changed the title
ti-chi-bot
bot
added
release-note
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57255 +/- ##
================================================
+ Coverage 72.8888% 73.4985% +0.6096%
================================================
Files 1672 1672
Lines 462231 462307 +76
================================================
+ Hits 336915 339789 +2874
+ Misses 104562 101842 -2720
+ Partials 20754 20676 -78
Flags with carried forward coverage won't be shown. Click here to find out more.
|
qw4990
approved these changes
Nov 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
ti-chi-bot
bot
added
needs-cherry-pick-release-8.5
|
In response to a cherrypick label: new pull request created to branch |
13 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Nov 15, 2024
Signed-off-by: ti-chi-bot <[email protected]>
13 tasks
|
In response to a cherrypick label: new pull request created to branch |
13 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Nov 15, 2024
Signed-off-by: ti-chi-bot <[email protected]>
13 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Nov 15, 2024
Signed-off-by: ti-chi-bot <[email protected]>
13 tasks
hawkingrei
added a commit
to ti-chi-bot/tidb
that referenced
this pull request
Dec 11, 2024
Signed-off-by: ti-chi-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #56726
Problem Summary:
What changed and how does it work?
delete tt1 from t1 tt1,(select max(id) id from t2)tt2 where tt1.id<=tt2.iddelete tt1will be transfer todelete current_database.t1in default when to deal with the statsment in thecreate binding.because
tt1cannot be used as alias in delete statement.so we have to set
tt1as alias by aliasChecker.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.